Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check response code for errors #218

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Check response code for errors #218

merged 1 commit into from
Jul 9, 2024

Conversation

sriniketh923
Copy link
Contributor

Check response code before unmarshaling response.Body. Sometimes the response code is 400 and the unmarshall errors out. This ensures that the errors are handled properly.

@sriniketh923 sriniketh923 requested review from a team as code owners July 8, 2024 20:32
benkeith-splunk
benkeith-splunk approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@benkeith-splunk benkeith-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@benkeith-splunk benkeith-splunk merged commit cbbf4ec into signalfx:master Jul 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benkeith-splunk benkeith-splunk benkeith-splunk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sriniketh923 @benkeith-splunk